Skip to content

Extension traits #2812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Oct 20, 2025
Merged

Extension traits #2812

merged 23 commits into from
Oct 20, 2025

Conversation

LukeMathWalker
Copy link
Contributor

@LukeMathWalker LukeMathWalker commented Jul 9, 2025 •
edited
Loading

No description provided.

@LukeMathWalker LukeMathWalker changed the base branch from main to idiomatic-rust July 9, 2025 17:07
@LukeMathWalker LukeMathWalker changed the base branch from idiomatic-rust to main July 9, 2025 19:03
@LukeMathWalker LukeMathWalker force-pushed the extension-traits branch 2 times, most recently from 9ad9fa7 to 9b50d50 Compare July 9, 2025 19:12
djmitche
djmitche reviewed Jul 9, 2025
View reviewed changes
Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

@LukeMathWalker LukeMathWalker marked this pull request as ready for review July 14, 2025 15:37
@LukeMathWalker LukeMathWalker requested a review from djmitche July 14, 2025 17:20
randomPoison
randomPoison requested changes Jul 14, 2025
View reviewed changes
Copy link
Collaborator

@randomPoison randomPoison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I only have a couple of minor comments, but on the whole I like it :)

gribozavr
gribozavr reviewed Jul 15, 2025
View reviewed changes
LukeMathWalker and others added 4 commits July 15, 2025 14:38
@LukeMathWalker @gribozavr
Update src/idiomatic/leveraging-the-type-system/extension-traits/exte…
5ab37d8 
…nding-foreign-types.md

Co-authored-by: Dmitri Gribenko <[email protected]>
@LukeMathWalker @gribozavr
Update src/idiomatic/leveraging-the-type-system/extension-traits/meth…
841bce5 
…od-resolution-conflicts.md

Co-authored-by: Dmitri Gribenko <[email protected]>
@LukeMathWalker @gribozavr
Update src/idiomatic/leveraging-the-type-system/extension-traits/meth…
aa2ab0f 
…od-resolution-conflicts.md

Co-authored-by: Dmitri Gribenko <[email protected]>
@LukeMathWalker @gribozavr
Update src/idiomatic/leveraging-the-type-system/extension-traits/meth…
63d3aa3 
…od-resolution-conflicts.md

Co-authored-by: Dmitri Gribenko <[email protected]>
@LukeMathWalker LukeMathWalker requested a review from gribozavr July 31, 2025 15:17
randomPoison
randomPoison requested changes Aug 1, 2025
View reviewed changes
Copy link
Collaborator

@randomPoison randomPoison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might want to change the examples in this section to not be on &str, since implementing a trait on a reference leads to confusing behavior around method resolution (which I talk about in more detail in one of the comments here). I think things would be less confusing if we used a non-reference type like i32 or struct Foo.

djmitche
djmitche approved these changes Aug 8, 2025
View reviewed changes
Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. The note below is stylistic and relates only to the speaker notes, so feel free to treat it as a mild preference at most.

gribozavr
gribozavr approved these changes Sep 21, 2025
View reviewed changes
@gribozavr
Copy link
Collaborator

@LukeMathWalker I left another round of comments, but please don't be discouraged - this section looks very good and the comments are mostly minor. Please work through resolving the comments, rebase the PR to resolve conflicts with main, and merge. You have my LGTM.

@gribozavr gribozavr added the waiting for author Waiting on the issue author to reply label Sep 21, 2025
@tall-vase tall-vase self-assigned this Oct 13, 2025
@tall-vase @gribozavr @randomPoison
Apply suggestions from code review
d141a8d 
Co-authored-by: Dmitri Gribenko <[email protected]>
Co-authored-by: Nicole L <[email protected]>
@gribozavr gribozavr merged commit 72cdf86 into google:main Oct 20, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tall-vase tall-vase tall-vase left review comments

@djmitche djmitche djmitche approved these changes

@gribozavr gribozavr gribozavr approved these changes

@randomPoison randomPoison Awaiting requested review from randomPoison

Assignees

@LukeMathWalker LukeMathWalker

@tall-vase tall-vase

Labels

deep_dives/idiomatic waiting for author Waiting on the issue author to reply

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LukeMathWalker @gribozavr @djmitche @randomPoison @tall-vase